Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PhysicsShapeQueryParameters3D.motion type wrongly set to Vector2 #85393

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Fix PhysicsShapeQueryParameters3D.motion type wrongly set to Vector2 #85393

merged 1 commit into from
Jan 2, 2024

Conversation

SomeRanDev
Copy link
Contributor

Maybe I'm missing something, but according to the getter/setter and documentation, this should be a Vector3.

@AThousandShips
Copy link
Member

AThousandShips commented Nov 26, 2023

Need to add compatibility notice for this change, see misc/extension_api_validation /4.1-stable.expected, add at the bottom of the file:



GH-85393
--------
Validate extension JSON: Error: Field 'classes/PhysicsShapeQueryParameters3D/properties/motion': type changed value in new API, from "Vector2" to "Vector3".

Original type was incorrect

Unsure the details to add further, i.e. if some instructions are needed

And once 4.2 has been released a 4.2 version of that will be added and you can add it to that

@SomeRanDev
Copy link
Contributor Author

Ahhh, thank you for the thorough explanation! Sorry for the trouble. 😅

And once 4.2 has been released a 4.2 version of that will be added and you can add it to that

So I shouldn't add it to the 4.1-stable.expected right now?

@AThousandShips
Copy link
Member

AThousandShips commented Nov 26, 2023

You can to get the CI finished, and then move it, or wait until after the new one has been added 🙂

@YuriSizov
Copy link
Contributor

You should be able to update your PR now, the required file has been added. 🙃

@akien-mga akien-mga changed the title Fix PhysicsShapeQueryParameters3D.motion type binding Fix PhysicsShapeQueryParameters3D.motion type binding Jan 2, 2024
@SomeRanDev SomeRanDev requested review from a team as code owners January 2, 2024 11:31
@akien-mga akien-mga changed the title Fix PhysicsShapeQueryParameters3D.motion type binding Fix PhysicsShapeQueryParameters3D.motion type wrongly set to Vector2 Jan 2, 2024
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased myself to add the compatibility statement.

Technically, this breaks compatibility AFAIK, but the previous binding was unusable.

@akien-mga akien-mga merged commit 5f97e40 into godotengine:master Jan 2, 2024
15 checks passed
@akien-mga
Copy link
Member

akien-mga commented Jan 2, 2024

Thanks! And congrats for your first merged Godot contribution 🎉

@SomeRanDev
Copy link
Contributor Author

Oh wow! Sorry, it's been a busy couple weeks and this completely slipped my mind. 🙇🙇
Thank you so much for putting together the final touches!!

@akien-mga akien-mga changed the title Fix PhysicsShapeQueryParameters3D.motion type wrongly set to Vector2 Fix PhysicsShapeQueryParameters3D.motion type wrongly set to Vector2 Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants