Use the flat button style on switches in scene and node docks #85236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should Node dock be changed too? It has icons, but the buttons are flat. |
|
Should these buttons be converted to use TabBar instead? |
YuriSizov
force-pushed
the
editor-flat-remote
branch
from
21b0d55
to
b1d6e33
Compare
Sure!
That was my initial idea back then, but I'm not sure it would work well inside of a dock which itself is a part of some tabs. I mean, mechanically they could. But visually I think something else is needed. |
YuriSizov
changed the title
groud
approved these changes
Dec 8, 2023
|
Thanks for reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #81939.
So I have always found these two buttons to be awkwardly designed. A lot of empty space, no panels, just accented text to show which is active. Never arrived to a better design myself, but now that we have the
FlatButtonstyle, thanks to #81939, I think it would be appropriate to use it here.It still feels a bit disconnected, but I think this is still better and it uses a consistent style from other parts of the editor. So should be a safe choice for now.
godot.windows.editor.dev.x86_64_2023-11-22_19-34-39.mp4