Remove GI methods in parentheses from light baking options #85219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, on lights, the "Bake Mode" property has 3 options:
I think this is potentially confusing (it confused me :-)) because it makes it sound like lights marked "Dynamic (VoxelGI/SDFGI)" won't be baked into
LightmapGI
lightmaps.However, they are baked into
LightmapGI
lightmaps, but only the bounced light, not the direct light.So, in this case, I think it'd be best to just remove the GI methods from the option names, since all the options do apply to all GI methods.
There are a number of other properties with similar options, for example,gi_mode
onVisualInstance3D
, but in that case I think it's OK because it's true (if marked as "Dynamic (VoxelGI only)" that visual instance won't receive light fromLightmapGI
). The same goes for themeshes/light_baking
option fromResourceImporterScene
.UPDATE: Per @Calinou's suggestion, this PR now removes the GI method names from all light baking options.