Restored Control properties when you undo a parenting of a Control to a Container #85181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Controls, in a rather hackish manner, have dedicated editor-only methods that can give you the entire state of the control which you can use to restore it later. I think this is what you should use here. |
TheSofox
force-pushed
the
reparent-container-undo-fix
branch
from
471e234
to
01329e6
Compare
|
It was that easy the whole time? Well, I've made the change, pushed, and on my end it works even better than before. |
YuriSizov
added
the
cherrypick:4.2
TheSofox
changed the title
KoBeWi
reviewed
Nov 22, 2023
TheSofox
force-pushed
the
reparent-container-undo-fix
branch
from
01329e6
to
5614e6d
Compare
KoBeWi
approved these changes
Nov 22, 2023
|
Thanks! |
|
Cherry-picked for 4.2.1. |
YuriSizov
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44629.
Previously if you added a Control to a Container that did automatic layout (Such as Button to VBoxLayout), then if you hit "Undo", the parenting would be undone, but the anchors and the size of the control would remain whatever the Container had set them to. This update fixes that.