Fetch argument options from ThemeDB #85015
Merged
+27
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
get_argument_options_for_your_invalid_argument
branch
from
c581ab2
to
44395b8
Compare
YuriSizov
suggested changes
Jan 12, 2024
There was a problem hiding this comment.
Some changes are required, plus a rebase, but otherwise it works as expected.
Edit: Also see #84763 (review), more changes are necessary.
|
Reordered the calls and rebased on top of e86750d |
KoBeWi
force-pushed
the
get_argument_options_for_your_invalid_argument
branch
from
44395b8
to
642b066
Compare
KoBeWi
force-pushed
the
get_argument_options_for_your_invalid_argument
branch
from
642b066
to
940329c
Compare
KoBeWi
force-pushed
the
get_argument_options_for_your_invalid_argument
branch
from
940329c
to
fc3049d
Compare
KoBeWi
force-pushed
the
get_argument_options_for_your_invalid_argument
branch
from
fc3049d
to
82b6f9d
Compare
akien-mga
approved these changes
May 7, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#82402 (comment)
Also adds missing autocompletion for icon methods.