Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makerst: Disallow user-contributed notes on the class index page #85006

Merged
merged 1 commit into from
Nov 17, 2023
Merged

makerst: Disallow user-contributed notes on the class index page #85006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/tools/make_rst.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1536,8 +1536,9 @@ def make_rst_index(grouped_classes: Dict[str, List[str]], dry_run: bool, output_
else:
f = open(os.path.join(output_dir, "index.rst"), "w", encoding="utf-8")

# Remove the "Edit on Github" button from the online docs page.
f.write(":github_url: hide\n\n")
# Remove the "Edit on Github" button from the online docs page, and disallow user-contributed notes
# on the index page. User-contributed notes are allowed on individual class pages.
f.write(":github_url: hide\n:allow_comments: False\n\n")

# Warn contributors not to edit this file directly.
# Also provide links to the source files for reference.
Expand Down
Loading