Allow disabling joypad support on Windows#84848
Allow disabling joypad support on Windows#84848jsjtxietian wants to merge 1 commit intogodotengine:masterfrom
Conversation
0446044 to
4576e68
Compare
4576e68 to
cf485c0
Compare
488e632 to
18e0210
Compare
18e0210 to
0c7a2f1
Compare
main/main.cpp
Outdated
There was a problem hiding this comment.
I think this should be moved to where other editor settings are defined so that it can be documented, I suspect it not being available for documentation is because either it occurs in the wrong place, or the doctool generation doesn't set editor to true
There was a problem hiding this comment.
Yes, initially I was thinking about get this editor setting defined before the joypad is initialized, but it seems it's too early. And now we have to find a place to define it, maybe in Input?
There was a problem hiding this comment.
You need to remove editor to make it work, it is not assigned when running the doctool, and shouldn't matter anyway as you're already in the tool check
It also needs to be moved up before the doctool is run, so up to 2905
There was a problem hiding this comment.
Sorry I don't get it, I understand now that I need to remove the editor check, but what do you mean by "It also needs to be moved up before the doctool is run" ? Sorry I don't understand the doctool part !
There was a problem hiding this comment.
The part that generates the documentation is tun on line 2905, hence why it needs to be moved up there 🙂
There was a problem hiding this comment.
Ah thanks, but anyway I think I need to move it to a later stage because now the EditorSettings is not instantiated yet. How stupid am I, I did not check the console error message.
Now the problem is, the joypad is inited before the EditorSettings, so editor def and get will not work, which means under the current implentation, the joypad editor setting is useless ( User can still use a command line arg but that;'s more work ).
There was a problem hiding this comment.
You should probably register it in the editor settings file, but might not work in any case as you say
project setting, command arg and windows support
0c7a2f1 to
54f2f9a
Compare
|
Might be superseded by #105513 , and now we don't have the |
On my way implementing godotengine/godot-proposals#8391