-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix node names of submenu items across the editor #84617
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -497,7 +497,10 @@ public override void _EnablePlugin() | |||||||||||
|
||||||||||||
AddChild(new HotReloadAssemblyWatcher { Name = "HotReloadAssemblyWatcher" }); | ||||||||||||
|
||||||||||||
_menuPopup = new PopupMenu(); | ||||||||||||
_menuPopup = new PopupMenu | ||||||||||||
{ | ||||||||||||
Name = "CSharpTools", | ||||||||||||
}; | ||||||||||||
Comment on lines
+500
to
+503
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't know what's the preferred style but I notice the
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe it's supposed to be inlined when it's just one property? cc @raulsntos There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I think we tend to inline them when it's just one property and the line is not overly long. But we don't really enforce this so we're probably not consistent everywhere. I think it's fine either way. |
||||||||||||
_menuPopup.Hide(); | ||||||||||||
|
||||||||||||
AddToolSubmenuItem("C#", _menuPopup); | ||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol