Fix StateMachine transition Sync not working on looped animations #84586
Conversation
|
You have spaces instead of tabs for indentation, you will need to fix this |
| @@ -178,7 +178,7 @@ double AnimationNodeAnimation::_process(const AnimationMixer::PlaybackInfo p_pla | |||
| } | |||
| set_parameter(time, cur_time); | |||
|
|
|||
| return is_looping ? HUGE_LENGTH : anim_size - cur_time; | |||
There was a problem hiding this comment.
We explained in #82089 that this change is currently inacceptable. This revision is being worked on as godotengine/godot-proposals#8083.
There was a problem hiding this comment.
To be fair, I absolutelly agree animationtree/node needs reworking, this PR is basically a makedo with what I got.
It's worth mentioning though, kinda like SkeletonIK3D, while reworking is mandatory, we do need something to work with when possible, after reading the proposal I understand my PR may cause more trouble than benefits, but I do hope we get something to work with in the meantime while animationtree gets reworked
|
Superseded by #87171. Thanks for the contribution! |
Fixes #79505
Also properly shows the statemachine node progress on looped animations (originally static and constantly maxed out)