Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocompletion: Mark datatype as constant for constant arrays #84492

Merged
merged 1 commit into from
May 7, 2024
Merged

Autocompletion: Mark datatype as constant for constant arrays #84492

merged 1 commit into from
May 7, 2024
+1 −0

Conversation

HolonProduction
Copy link
Member

Fixes #77725

@HolonProduction HolonProduction requested a review from a team as a code owner November 5, 2023 21:02
@AThousandShips AThousandShips added this to the 4.3 milestone Nov 5, 2023
Mickeon
Mickeon approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging by the code that handles this same thing for DICTIONARY this feels like an accidental omission.

@AThousandShips AThousandShips changed the title Autocompletion: mark datatype as constant for constant arrays Autocompletion: Mark datatype as constant for constant arrays Mar 2, 2024
@akien-mga akien-mga requested review from vnen and dalexeev May 7, 2024 13:27
vnen
vnen approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@vnen vnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve in the GDScript meeting

@akien-mga akien-mga merged commit d83586f into godotengine:master May 7, 2024
17 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnen vnen vnen approved these changes

@dalexeev dalexeev dalexeev approved these changes

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Code Completion for dictionaries doesn't work when the Value is an array
6 participants
@HolonProduction @akien-mga @vnen @dalexeev @Mickeon @AThousandShips