Extend CanvasItem::draw_circle(), making it also draw unfilled circle.

[xiongyaohua]

func _draw():
	draw_circle(Vector2(0,200), 200, Color.BROWN)
	draw_circle(Vector2(300,200), 200, Color.BROWN, false)
	draw_circle(Vector2(600,200), 200, Color.BROWN, false, 10)

• Bugsquad edit, closes: Add filled and width parameters to draw_circle godot-proposals#7761

[AThousandShips]

Please see this

[MewPurPur]

Random thought but already too late for it, I noticed that the circle-drawing pipelines could easily be extended for ellipses without any overhead. I'll try to remember to bring this up for 5.0

[MewPurPur]

Looks good to me.

[MewPurPur]

Also consider the suggestion for adding an antialiased parameter, and documenting that it only works for unfilled.

[xiongyaohua]

Also consider the suggestion for adding an antialiased parameter, and documenting that it only works for unfilled.

Beside this PR I find there are several other inconsistencies in the Canvasitem draw API. I am going to make a proposal then address them in an following PR.

[AThousandShips]

This was not necessarily a suggestion in the proposal, so I'd say it should be added now instead of later

And new functionality shouldn't add to the inconsistencies IMO

[xiongyaohua]

Let me explain. The inconsistencies include:

1. if there is p_antialiased for draw_circle, then there should also be p_antialiased for draw_rect.
2. if p_antialiased works for unfilled version of circle or rect, then it should works for filled versions.
3. if p_antialiased works for line and polyline, then it should works for dashed_line and multiline

I plan to address them step by step, instead of mixed all things in one big PR. The plan is:

• next PR: add p_antialiased for unfilled version of both circle and rect. If p_antialiased is add to circle in current PR, then we are in the position that the circle support antialias while the rect doesn't. So I prefer to add it to both in the next PR.
• then: make p_antialiased works for filled circle and rect, using the same "feather" method as the antialiased line
• then: add p_antialiased to dashed_line and multiline

edit:

• 1 and 3 are handled in Add anti alias support for linear Canvasitem draw primitives #84497
• 2 is handled in CanvasItem draw implement antialiasing for circle, rect, multiline, and dashedline #84523

[MewPurPur]

OK! I look forward. I think this is good as is.

[MewPurPur]

Actually, maybe @dalexeev has something to say about this, having worked on draw_rect() a while back. I remember daleexev struggling to figure out whether increasing width should make the rect's stroke should grow inward, outward, or in both directions.

[Calinou]

Random thought but already too late for it, I noticed that the circle-drawing pipelines could easily be extended for ellipses without any overhead. I'll try to remember to bring this up for 5.0

This can be done in a backwards-compatible way by adding draw_ellipse(), but it should be discussed in its own proposal.

[xiongyaohua]

The Mono build always give error, because of some API mismatching. But I am not sure how should I proceed to solve it, can someone shed some light?

[MewPurPur]

It's fine, you don't need to change anything. Edit: Nevermind, sorry

[xiongyaohua]

It's fine, you don't need to change anything.

Good to know, thanks!

[AThousandShips]

It's fine, you don't need to change anything.

This is false, you need to provide compatibility methods, this is for GDExtension, this is required when ever additional arguments are added, take a look in other files which have a .compat.inc file associated with them

[AThousandShips]

LGTM, will need some dedicated render review to be sure but it matches the general method for this

Just some minor nitpicks

[Calinou]

I suggest adding a final antialiased parameter that defaults to false, and passes this parameter to canvas_item_add_polyline().

[AThousandShips]

That is currently handled in a separate follow-up PR:

• CanvasItem draw implement antialiasing for circle, rect, multiline, and dashedline #84523

But I'd agree that doing it in one PR is most convenient and makes it less cumbersome compatibility wise

[xiongyaohua]

I suggest adding a final antialiased parameter that defaults to false, and passes this parameter to canvas_item_add_polyline().

done

[xiongyaohua]

@AThousandShips Might this PR be considered to be moved to 4.3? The change is relatively straightforward and small in scope, yet the improve in user convenience is considerable.

[AThousandShips]

No rush 🙂 it still needs some further review by render the render team before it can be decided on merger

This addition might be straightforward, but we need to be careful about how we decide to go with it so we don't have to change it and break compatibility in the future, so a thought through decision is needed

[xiongyaohua]

Fair enough, thanks for the explanation.

[AThousandShips]

Should now be moved to the 4.2 file since it exists

[xiongyaohua]

done

[Calinou]

Tested locally (rebased on top of master 6118592), it works as expected in all rendering methods, with and without HDR 2D enabled.

Testing project: test-draw-circle.zip

[akien-mga]

Needs a rebase, and then this should be mergeable.

[AThousandShips]

Just a minor detail

[akien-mga]

Thanks!