Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify pull request builds from GitHub Actions with the PR number #83448

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 16, 2023

This makes it easier to go back to the pull request the build was made from. The build name is displayed in the Project Manager, editor About dialog and editor version tooltip (at the bottom of the editor). It's also copied within the Copy System Information text.

Preview

GitHub Actions build from a push

Screenshot_20231016_062303

GitHub Actions build from a pull request

PR number is 11 in this example (I was testing on my fork).

Screenshot_20231016_062321

This makes it easier to go back to the pull request the build was
made from.
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea, and the code looks pretty simple. I believe it should not conflict with anything, as if users are overriding the build name in the CI scons command that will take priority over the export variable.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jan 5, 2024
@akien-mga akien-mga merged commit 31df756 into godotengine:master Jan 5, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the github-actions-identify-pr-builds branch January 8, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants