C#: Untyped to typed ArgumentNullException
#83051
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally part of #82983, before one of the discussions prompted me to check if adding
ArgumentNullException
to the untyped→typed constructors would break compatability. As it turns out, it would not, because they always expect the underlying collection to be valid. However, this does mean that it wasn't throwing an exception earlier, only when an actual function is called, so the exception in the constructor is warrantedIn addition, this adds missing exception/returns documentation for the two files. It was already warranted for the constructors having a new exception, but this ensures similar relevant functions have appropriate documentation if it was similarly missing
Test case::
Old behavior log, caught on line 3:
New behavior log, caught on line 2: