Fix saving branch as scene saves children without owner set

[marcinn]

Fixes #82756 and preserves fix for #42611

[KoBeWi]

With this, the changes from #61966 might not be necessary anymore.

[marcinn]

With this, the changes from #61966 might not be necessary anymore.

I prefer to separate this fix from reverting the other one. I'm not sure if there is a use case where an internal node has an owner set. I'm afraid that reverting #61966 may (re)introduce some issues. Preserving both for a while will be safer for stability.

[Rindbee]

Maybe just pass in the corresponding base (child) nodes and find their owners, if the number of their child nodes is the same (Will it be different?).

[marcinn1]

Thanks for suggestions 👍 , I'll look at them and improve the code as soon as possible.

[YuriSizov]

@marcinn1 @marcinn (not sure which account you're actively using?)

Just bumping to remind you about unresolved review comments. This can't make it into 4.2 at this point, but if you could find time to address the notes above, this should help to move this PR along.

[marcinn1]

Thanks. I'd look at this at evening.

[marcinn1]

I've rebased the branch, added suggested changes (excl r_ prefix), tested with MRP. Seems to be ok.

[KoBeWi]

There are a couple of unresolved minor comments, but otherwise looks ok.

[marcinn1]

There are a couple of unresolved minor comments, but otherwise looks ok.

Should I add these changes before merging?

[KoBeWi]

Yep.

[marcinn1]

Yep.

OK, this evening.

[marcinn1]

Updated.

Ok it is necessary, but in this situations we normally use const_cast<>.

Thanks for reminding me why I abandoned c++ ~20yrs ago ;)

[akien-mga]

Thanks!