Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading floating dock layout #82742

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix loading floating dock layout #82742

merged 1 commit into from
Oct 13, 2023

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented Oct 3, 2023

Switching between editor layouts with floating docks now works correctly.
fix #81162
fix #80748

trollodel
trollodel approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@trollodel trollodel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this, but changes seems good to me.

@akien-mga akien-mga added this to the 4.2 milestone Oct 3, 2023
@akien-mga akien-mga requested a review from a team October 3, 2023 20:22
@akien-mga akien-mga merged commit 230bdda into godotengine:master Oct 13, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@kitbdev kitbdev deleted the empty-dock-layout branch October 13, 2023 12:28
@kitbdev
Copy link
Contributor Author

kitbdev commented Oct 13, 2023

Thank you!

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga Not my first contribution, It's just been a few years and I changed my github username from @ianb96 to @kitbdev.

@akien-mga
Copy link
Member

Welcome back then :)

This was referenced Oct 15, 2023
Closed
Closed
@kitbdev kitbdev mentioned this pull request Oct 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trollodel trollodel trollodel approved these changes

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.2
4 participants
@kitbdev @akien-mga @KoBeWi @trollodel