-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add set_custom_interpolator()
to PropertyTweener
#82306
Conversation
79d0d5c
to
dcc7b33
Compare
Would it not be better to call the method I would also suggest a few changes to the description to avoid confusing the user with the terms "easing" and "transition".
I also suggest adding a warning inside One final suggestion is to rename the callable |
Not sure. |
I see... I didn't notice that part as I was following the proposal text that said they would cancel each other out. How about Interpolator is generic, but more descriptive and also doesn't collide with transition or ease. |
dcc7b33
to
320768a
Compare
Renamed. |
set_custom_method()
to PropertyTweenerset_custom_interpolator()
to PropertyTweener
320768a
to
d4c64b6
Compare
d4c64b6
to
fb0d655
Compare
fb0d655
to
58f4984
Compare
Thanks! |
Closes godotengine/godot-proposals#7807
Probably solves godotengine/godot-proposals#1251
godot.windows.editor.dev.x86_64_VsCyflxhek.mp4
(see the example in the docs)