Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds additional tests for RegEx class #82225

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Adds additional tests for RegEx class #82225

merged 1 commit into from
Sep 26, 2023

Conversation

BrunoArmondBraga
Copy link
Contributor

This PR improves the coverage of the unit tests for RegEx class.
Improves RegEx substitution tests and RegExMatch search tests. Also creates tests for get_strings, get_start, get_end from RegExMatch class.

This task was part of #43440

@BrunoArmondBraga BrunoArmondBraga requested a review from a team as a code owner September 24, 2023 06:01
@YeldhamDev YeldhamDev added this to the 4.x milestone Sep 24, 2023
@Calinou Calinou mentioned this pull request Sep 26, 2023
Open
99 tasks
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Sep 26, 2023
@akien-mga akien-mga merged commit 446c1fa into godotengine:master Sep 26, 2023
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@Scoppio Scoppio Scoppio approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:tests
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@BrunoArmondBraga @akien-mga @Scoppio @AThousandShips @YeldhamDev