-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Texture2D and Texture3D icons #81169
Conversation
Could you force-push your PR so the CI runs again? |
886fda4
to
6cdd406
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Godot has R-dimensional textures now? :O No idea what these are or what would work for them. Hmu if you have ideas or if you can suggest something. |
RD stands for Based on the docs it looks like they reference a texture created directly on the I'm not really sure how that could be conveyed. Maybe you could draw "RD" inside, somehow pair it to a GPU symbol (I think that'd be a fair generalization) or maybe an arrow, to represent that it's actually somewhere else? |
I was making a joke 😓 The GPU thingy sounds interesting, but I realized we don't have any kind of common convention for it. CPU has one (on CPUParticles) which would've been cool, but... yeah it's an association with CPUs, I think it wouldn't be ugly, but it's wrong in a way that would irk people easily. GPUs don't seem to have any conventional icons people would find familiar as far as I see. So as I see it, I'll have to think of something more abstract to do for it and its 3D analogue. |
Thanks! |
Cherry-picked for 4.2.2. |
Texture2D and Texture3D have quite established shapes, so I think we should make use of it for the abstract classes, to help with visual grepping when they're folded in the Create dialog.