Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix JavaScript callback memory leak #81090

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

SysError99
Copy link
Contributor

This fixes #81005 as I noticed that the original codecase doesn't free up allocated array after use in JS side, hence the issue, and Godot pretty much already copied everything from array to its internal Array, rendering the need to keep it intact unnecessary.

@SysError99 SysError99 requested a review from a team as a code owner August 28, 2023 20:25
@Calinou Calinou added bug topic:core topic:porting performance cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Aug 28, 2023
@Calinou Calinou added this to the 3.6 milestone Aug 28, 2023
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great 🏆
Thank you for debugging and fixing this 🥳 !

@akien-mga akien-mga merged commit 1012078 into godotengine:3.x Sep 6, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.3.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Sep 6, 2023
@SysError99 SysError99 deleted the 3.x-fix-js-callback-mem-leak branch September 7, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants