Add a Preview Bake button for quick iteration with LightmapGI #80518
+169
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
editor-add-lightmapgi-preview-bake
branch
2 times, most recently
from
21b7e3b
to
5540675
Compare
|
Note that as mentioned on the 3.x PR, you can use the preview bake in your projects if your computer is too weak to handle the full bake. |
Calinou
force-pushed
the
editor-add-lightmapgi-preview-bake
branch
2 times, most recently
from
f6148ed
to
4691061
Compare
|
is this implemented? |
|
@verypleasentusername No, this PR is still very much open. |
Calinou
force-pushed
the
editor-add-lightmapgi-preview-bake
branch
from
4691061
to
28e5f04
Compare
|
Rebased and tested again, it works as expected.
|
YuriSizov
reviewed
Jan 19, 2024
YuriSizov
reviewed
Jan 19, 2024
When using the Preview Bake button instead of Bake Lightmaps, low quality settings will be used instead of settings from the LightmapGI node. A node configuration warning will be displayed besides the LightmapGI node to inform the user that the bake was done in preview mode. This preview bake warning is persisted to storage to make teamwork easier. This helps iterate quicker on a scene's lighting since you don't need to wait as much time to see results. On a simple test scene, Preview Bake is about 3 times faster than a "final" bake with the default LightmapGI settings (if denoising is not the bottleneck). This metric will vary depending on CPU and GPU speed, as the baking process is performed on the GPU but denoising is performedon the CPU. The preview bake settings can be adjusted in the Project Settings. This also prints a message with the effective quality settings before beginning the lightmapping process.
Calinou
force-pushed
the
editor-add-lightmapgi-preview-bake
branch
from
28e5f04
to
0b22b12
Compare
|
Could this be merged? |
4.3 is currently in release freeze, so new features can only be merged in 4.4 at the earliest. In the meantime, you can decrease Texel Scale before baking and increase it again after baking. This is the single largest contributing factor to bake times in my experience. |
|
Yep! That's what I am doing. Good to hear that this will be considered for 4.4 though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterversion of [3.x] Add a Preview Bake button for quick iteration with BakedLightmap #45237.When using the Preview Bake button instead of Bake Lightmaps, low quality settings will be used instead of settings from the LightmapGI node. A node configuration warning will be displayed
besides the LightmapGI node to inform the user that the bake was done in preview mode. This preview bake warning is persisted to storage to make teamwork easier.
This helps iterate quicker on a scene's lighting since you don't need to wait as much time to see results.
On a simple test scene, Preview Bake is about 3 times faster than a "final" bake with the default LightmapGI settings (if denoising is not the bottleneck). This metric will vary depending on CPU and GPU speed, as the baking process is performed on the GPU but denoising is performed on the CPU.
The preview bake settings can be adjusted in the Project Settings.
This also prints a message with the effective quality settings before beginning the lightmapping process.
Testing project: test_lightmap_preview_bake_4.x.zip
Preview
BakePreview bake result
Note
Tangents are a bit broken on this scene, so there are artifacts that would usually not appear.
4 seconds to bake.
"Final" bake result
16 seconds to bake.