Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize and tweak the new Camera icons #80436

Closed
wants to merge 1 commit into from
Closed

Optimize and tweak the new Camera icons #80436

wants to merge 1 commit into from

Conversation

MewPurPur
Copy link
Contributor

Before

image

After

image

The reduction of the top part is a bit arbitrary I guess, but I think it was way too exaggerated, gave me goose egg vibes

@MewPurPur MewPurPur requested a review from a team as a code owner August 8, 2023 22:16
@YeldhamDev
Copy link
Member

YeldhamDev commented Aug 9, 2023 •
edited
Loading

What's the reason for the gizmo one to look different?

@Calinou
Copy link
Member

Calinou commented Aug 9, 2023 •
edited
Loading

The ClippedCamera3D icon can be removed as that node was removed in 4.0.

@Calinou Calinou added this to the 4.x milestone Aug 9, 2023
@MewPurPur
Copy link
Contributor Author

MewPurPur commented Aug 9, 2023 •
edited
Loading

Oh? I thought I've seen it, must've been the XR one

Why gizmo looks different?

Different than the rest because its context allows for more detail. Different than before to remove some artifacts, make it symmetrical, etc.

@MewPurPur
Copy link
Contributor Author

Tweaked the camera gizmo for a slightly less massive hole in the middle, and removed ClippedCamera

@Mickeon
Copy link
Contributor

Mickeon commented Aug 9, 2023 •
edited
Loading

Why have the asterisks on the CameraAttributes switched color between Physical and Practical?

Also, here's a gif for comparison, too
Before-After

@MewPurPur
Copy link
Contributor Author

Oop, swapped when copy pasting.

This is a new icon in 4.2 though, and blue is more associated with physics anyway (it's the physics shape color) so I'm lazy to change it unless asked P:

@MewPurPur MewPurPur closed this Aug 21, 2023
@MewPurPur MewPurPur deleted the cam-icon-optimize branch August 21, 2023 23:58
@AThousandShips AThousandShips removed this from the 4.x milestone Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
archived enhancement topic:editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MewPurPur @YeldhamDev @Calinou @Mickeon @AThousandShips