[Web] Use fvisibility=hidden for side module when dlink_enabled.
#79578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hugely reduces the number of exports, making it acceptable for browsers. Note that dlink + threads is still not working due to upstream issues with the pthread emulation library. Should hopefully be solved once emscripten move to native WASM threads.
akien-mga
approved these changes
Aug 16, 2023
akien-mga
changed the title
fvisibility=hidden for side module when dlink_enabled.
|
Thanks! |
akien-mga
changed the title
fvisibility=hidden for side module when dlink_enabled.fvisibility=hidden for side module when dlink_enabled.
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hugely reduces the number of exports, making it acceptable for browsers.
See emscripten-core/emscripten#15487 (comment)
Note that dlink + threads is still not working due to upstream issues with the pthread emulation library (suspected root cause: emscripten-core/emscripten#19425 ).
Should hopefully be solved once emscripten move to native WASM threads.