Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vararg call() method to C++ Callable #79341

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Add vararg call() method to C++ Callable #79341

merged 1 commit into from
Oct 5, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jul 11, 2023

Follow-up to #67730

@KoBeWi KoBeWi added this to the 4.x milestone Jul 11, 2023
@KoBeWi KoBeWi requested review from a team as code owners July 11, 2023 14:20
@dsnopek dsnopek mentioned this pull request Jul 11, 2023
Merged
@KoBeWi KoBeWi force-pushed the callp_without_p_is_just_call branch 3 times, most recently from b4d2d7c to c400375 Compare July 11, 2023 15:01
@KoBeWi KoBeWi mentioned this pull request Oct 4, 2023
Open
@KoBeWi KoBeWi force-pushed the callp_without_p_is_just_call branch from c400375 to bb5d401 Compare October 4, 2023 23:07
@KoBeWi KoBeWi requested a review from a team as a code owner October 4, 2023 23:07
@akien-mga akien-mga removed request for a team October 4, 2023 23:10
RandomShaper
RandomShaper approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@RandomShaper RandomShaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and is very welcome! To me, ready for merging once the build error is fixed.

@KoBeWi KoBeWi force-pushed the callp_without_p_is_just_call branch from bb5d401 to 8f14fd9 Compare October 5, 2023 09:19
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Oct 5, 2023
@KoBeWi KoBeWi force-pushed the callp_without_p_is_just_call branch from 8f14fd9 to 09b30be Compare October 5, 2023 09:35
@akien-mga akien-mga merged commit 57256d7 into godotengine:master Oct 5, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the callp_without_p_is_just_call branch October 5, 2023 10:50
@dpalais dpalais mentioned this pull request Oct 11, 2023
Closed
@YuriSizov YuriSizov mentioned this pull request Oct 24, 2023
Merged
@YuriSizov YuriSizov mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@RandomShaper RandomShaper RandomShaper approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@KoBeWi @akien-mga @RandomShaper @AThousandShips