C#: Add null check before calling `UnregisterGodotObject` #79151

RedworkDE · 2023-07-07T11:14:16Z

Not sure under which condition this can happen, but all calls to UnregisterDisposable have this check already (and there are no other calls to UnregisterGodotObject)

akien-mga

Tested, I confirm this fixes the crash for me.

The project still has a million errors but that's a different issue (partially from the project itself, maybe some we need to fix once better debugged).

akien-mga · 2023-07-07T14:10:51Z

Thanks!

YuriSizov · 2023-07-10T15:28:32Z

Cherry-picked for 4.1.1.

C#: Add null check before calling UnregisterGodotObject

693e6e0

RedworkDE added bug topic:dotnet crash cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 7, 2023

RedworkDE added this to the 4.2 milestone Jul 7, 2023

RedworkDE requested a review from a team as a code owner July 7, 2023 11:14

akien-mga approved these changes Jul 7, 2023

View reviewed changes

akien-mga merged commit c3b0a92 into godotengine:master Jul 7, 2023

YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 10, 2023

RedworkDE deleted the net-unregister-godotobject-check branch July 10, 2023 16:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

C#: Add null check before calling `UnregisterGodotObject` #79151

C#: Add null check before calling `UnregisterGodotObject` #79151

RedworkDE commented Jul 7, 2023

akien-mga left a comment

akien-mga commented Jul 7, 2023

YuriSizov commented Jul 10, 2023

C#: Add null check before calling UnregisterGodotObject #79151

C#: Add null check before calling UnregisterGodotObject #79151

Conversation

RedworkDE commented Jul 7, 2023

akien-mga left a comment

Choose a reason for hiding this comment

akien-mga commented Jul 7, 2023

YuriSizov commented Jul 10, 2023

C#: Add null check before calling `UnregisterGodotObject` #79151

C#: Add null check before calling `UnregisterGodotObject` #79151