-
-
Notifications
You must be signed in to change notification settings - Fork 20.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize dialog input validation as a new class #78744
Merged
akien-mga
merged 1 commit into
godotengine:master
from
KoBeWi:easy_peasy_routine_refactor_stuff
Aug 8, 2023
+382
−341
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,134 @@ | ||
| /**************************************************************************/ | ||
| /* editor_validation_panel.cpp */ | ||
| /**************************************************************************/ | ||
| /* This file is part of: */ | ||
| /* GODOT ENGINE */ | ||
| /* https://godotengine.org */ | ||
| /**************************************************************************/ | ||
| /* Copyright (c) 2014-present Godot Engine contributors (see AUTHORS.md). */ | ||
| /* Copyright (c) 2007-2014 Juan Linietsky, Ariel Manzur. */ | ||
| /* */ | ||
| /* Permission is hereby granted, free of charge, to any person obtaining */ | ||
| /* a copy of this software and associated documentation files (the */ | ||
| /* "Software"), to deal in the Software without restriction, including */ | ||
| /* without limitation the rights to use, copy, modify, merge, publish, */ | ||
| /* distribute, sublicense, and/or sell copies of the Software, and to */ | ||
| /* permit persons to whom the Software is furnished to do so, subject to */ | ||
| /* the following conditions: */ | ||
| /* */ | ||
| /* The above copyright notice and this permission notice shall be */ | ||
| /* included in all copies or substantial portions of the Software. */ | ||
| /* */ | ||
| /* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, */ | ||
| /* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF */ | ||
| /* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. */ | ||
| /* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY */ | ||
| /* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, */ | ||
| /* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE */ | ||
| /* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ | ||
| /**************************************************************************/ | ||
|
|
||
| #include "editor_validation_panel.h" | ||
|
|
||
| #include "editor/editor_scale.h" | ||
| #include "scene/gui/box_container.h" | ||
| #include "scene/gui/button.h" | ||
| #include "scene/gui/label.h" | ||
|
|
||
| void EditorValidationPanel::_update() { | ||
| for (const KeyValue<int, String> &E : valid_messages) { | ||
| set_message(E.key, E.value, MSG_OK); | ||
| } | ||
|
|
||
| valid = true; | ||
| update_callback.callv(Array()); | ||
|
|
||
| if (accept_button) { | ||
| accept_button->set_disabled(!valid); | ||
| } | ||
| pending_update = false; | ||
| } | ||
|
|
||
| void EditorValidationPanel::_notification(int p_what) { | ||
| switch (p_what) { | ||
| case NOTIFICATION_THEME_CHANGED: { | ||
| theme_cache.valid_color = get_theme_color(SNAME("success_color"), SNAME("Editor")); | ||
| theme_cache.warning_color = get_theme_color(SNAME("warning_color"), SNAME("Editor")); | ||
| theme_cache.error_color = get_theme_color(SNAME("error_color"), SNAME("Editor")); | ||
| } break; | ||
| } | ||
| } | ||
|
|
||
| void EditorValidationPanel::add_line(int p_id, const String &p_valid_message) { | ||
| ERR_FAIL_COND(valid_messages.has(p_id)); | ||
|
|
||
| Label *label = memnew(Label); | ||
| message_container->add_child(label); | ||
| label->set_custom_minimum_size(Size2(200 * EDSCALE, 0)); | ||
| label->set_autowrap_mode(TextServer::AUTOWRAP_WORD_SMART); | ||
|
|
||
| valid_messages[p_id] = p_valid_message; | ||
| labels[p_id] = label; | ||
| } | ||
|
|
||
| void EditorValidationPanel::set_accept_button(Button *p_button) { | ||
| accept_button = p_button; | ||
| } | ||
|
|
||
| void EditorValidationPanel::set_update_callback(const Callable &p_callback) { | ||
| update_callback = p_callback; | ||
| } | ||
|
|
||
| void EditorValidationPanel::update() { | ||
| ERR_FAIL_COND(update_callback.is_null()); | ||
|
|
||
| if (pending_update) { | ||
| return; | ||
| } | ||
| pending_update = true; | ||
| callable_mp(this, &EditorValidationPanel::_update).call_deferred(); | ||
| } | ||
|
|
||
| void EditorValidationPanel::set_message(int p_id, const String &p_text, MessageType p_type, bool p_auto_prefix) { | ||
| ERR_FAIL_COND(!valid_messages.has(p_id)); | ||
|
|
||
| Label *label = labels[p_id]; | ||
| if (p_text.is_empty()) { | ||
| label->hide(); | ||
| return; | ||
| } | ||
| label->show(); | ||
|
|
||
| if (p_auto_prefix) { | ||
| label->set_text(String(U"• ") + p_text); | ||
| } else { | ||
| label->set_text(p_text); | ||
| } | ||
|
|
||
| switch (p_type) { | ||
| case MSG_OK: | ||
| label->add_theme_color_override(SNAME("font_color"), theme_cache.valid_color); | ||
| break; | ||
| case MSG_WARNING: | ||
| label->add_theme_color_override(SNAME("font_color"), theme_cache.warning_color); | ||
| break; | ||
| case MSG_ERROR: | ||
| label->add_theme_color_override(SNAME("font_color"), theme_cache.error_color); | ||
| valid = false; | ||
| break; | ||
| case MSG_INFO: | ||
| label->remove_theme_color_override(SNAME("font_color")); | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| bool EditorValidationPanel::is_valid() const { | ||
| return valid; | ||
| } | ||
|
|
||
| EditorValidationPanel::EditorValidationPanel() { | ||
| set_v_size_flags(SIZE_EXPAND_FILL); | ||
|
|
||
| message_container = memnew(VBoxContainer); | ||
| add_child(message_container); | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be
_update_theme_item_cache, though in such a small class it doesn't change much.