-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change light themes default contrast from -0.08 to -0.06 #78297
Conversation
-0.08 overblows the highlights, -0.06 looks much better.
Can you take screenshots to compare before/after in the editor? |
Oh, hmm.. I just noticed something. The light themes in godot 4 seem broken beyond what I initially thought. At first, I only noticed the overblown highlights. But I went back to compare with godot 3 and the light themes in godot 3 are correct. See the solarized light theme in godot 3 (default settings): And in godot 4, the colors are overblown and the minimap has no highlight (default settings): This PR somewhat fixes the overblown colors in godot 4, but the minimap highlight is still missing. I double checked different godot 4 versions and the issue is present in all these versions: |
Should I close this PR and open an issue instead? |
I think you can keep this PR open, but please open an issue for the minimap theming regression. |
Thanks! And congrats for your first merged Godot contribution 🎉 |
I'm a light theme user and I felt like something was wrong with the light themes in godot. The issue was the negative contrast being a little bit too low, -0.08 overblows the highlights far too much. A small correction to -0.06 looks much better!
To save the time of other light theme users, I think it's a good idea to make that fix so that light themes look correct by default.