Document the upsides and downsides of packed arrays versus typed arrays #78257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
doc-packed-arrays-vs-typed-arrays
branch
from
dbd72a0
to
952dadd
Compare
Calinou
commented
Jun 15, 2023
| @@ -40,6 +40,7 @@ | |||
| [/codeblocks] | |||
| [b]Note:[/b] Arrays are always passed by reference. To get a copy of an array that can be modified independently of the original array, use [method duplicate]. | |||
| [b]Note:[/b] Erasing elements while iterating over arrays is [b]not[/b] supported and will result in unpredictable behavior. | |||
There was a problem hiding this comment.
By the way, does this also apply to packed arrays?
dalexeev
reviewed
Jun 15, 2023
akien-mga
added
cherrypick:4.1
In my opinion it's worth it, for better discoverability. But this is not good for translators. If we make the paragraph identical for all |
dalexeev
reviewed
Jul 17, 2023
YuriSizov
removed
the
cherrypick:4.1
Calinou
force-pushed
the
doc-packed-arrays-vs-typed-arrays
branch
2 times, most recently
from
ee9c0a8
to
22730be
Compare
Calinou
force-pushed
the
doc-packed-arrays-vs-typed-arrays
branch
from
22730be
to
ab8c9b6
Compare
mhilbrunner
approved these changes
Apr 7, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've only added descriptions to Array and PackedColorArray so far. Let me know if it's good to go and I'll add similar descriptions to other Packed*Array types.