Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix orientation change in runtime. #78132

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 12, 2023

Fixes #76940

Note: for dynamic orientation change to work, display/window/handheld/orientation setting must be set sensor, since it determine set orientations supported by app.

@bruvzg bruvzg added this to the 4.x milestone Jun 12, 2023
@bruvzg bruvzg requested a review from a team as a code owner June 12, 2023 08:00
@akien-mga akien-mga modified the milestones: 4.x, 4.1 Jun 12, 2023
@akien-mga
Copy link
Member

Note: for dynamic orientation change to work, display/window/handheld/orientation setting must be set sensor, since it determine set orientations supported by app.

This should maybe be documented in OS.set_screen_orientation?

@akien-mga akien-mga added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:4.0 labels Jun 12, 2023
@bruvzg bruvzg requested a review from a team as a code owner June 12, 2023 11:14
@akien-mga akien-mga merged commit b2335c0 into godotengine:master Jun 12, 2023
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the ios_rt_orient branch June 12, 2023 12:21
@maran
Copy link

maran commented Jun 27, 2023

Is there any way of knowing when this fix will hit a 3.x release?

@AThousandShips
Copy link
Member

I would expect I'd be cherrypicked for 3.6, with an accompanying cherrypick for the next 3.5.x release, current focus is 4.1 so updates on the release of 3.6 will probably come some time after that

@maran
Copy link

maran commented Sep 5, 2023

Just checking back in to see if this was cherrypicked for a coming 3.x release.

@AThousandShips
Copy link
Member

AThousandShips commented Sep 5, 2023

It has not yet, see on the labels, it still says "cherrypick:3.x" :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:3.x Considered for cherry-picking into a future 3.x release platform:ios topic:porting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting screen orientation at run-time not working on iOS
4 participants