Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScript: Change default value for untyped exported variables #77875

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Jun 5, 2023

Closes #74188.

See also comments in #74231 and #75555.

Formally, this breaks compatibility, but only in a small number of cases, and we assume that users expect this behavior rather than the current one. However, it needs to be documented anyway.

@vnen
Copy link
Member

vnen commented Apr 30, 2024

Reviving this, do we want to move forward? I wonder what's the solution for invalid default values (e.g. when 0 is outside the range or does not belong to the define enum). AFAIK the inspector still hasn´t been fixed for those cases.

Technically, since the annotation arguments are constants we could pick a valid default, but I'm not sure if it's worth the trouble.

@dalexeev
Copy link
Member Author

Reviving this, do we want to move forward? I wonder what's the solution for invalid default values (e.g. when 0 is outside the range or does not belong to the define enum). AFAIK the inspector still hasn´t been fixed for those cases.

I think this should be resolved only on the inspector's side.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using export_multiline should default to a blank string, not null
3 participants