Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] VisibilityEnabler2D - rename hide_parent and change default #77656

Closed
wants to merge 1 commit into from

Conversation

lawnjelly
Copy link
Member

Renames "parent_visibility" to "hide_parent", and changes the default to off to preserve backward compatibility.

Notes

Renames "parent_visibility" to "hide_parent", and changes the default to off to preserve backward compatibility.
@lawnjelly lawnjelly requested review from a team as code owners May 30, 2023 10:11
@lawnjelly lawnjelly added this to the 3.6 milestone May 30, 2023
@lawnjelly lawnjelly marked this pull request as draft May 30, 2023 11:17
@lawnjelly
Copy link
Member Author

Actually hold off on this, I've been doing the flags PR and it is actually a barrel of worms, so I'm re-evaluating whether it would be better to revert #63193 and just rely on #68738 instead (which does all this server side, so doesn't suffer from the flag logic problems).

@akien-mga akien-mga changed the title VisibilityEnabler2D - rename hide_parent and change default [3.x] VisibilityEnabler2D - rename hide_parent and change default Jun 7, 2023
@akien-mga
Copy link
Member

Superseded by #78182.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants