Fix center of mass when importing GLTF physics bodies #77602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also this PR where I am making the behavior explicit in the spec omigroup/gltf-extensions#167
The one thing I'm unsure of is with exporting, if we want to bake in a custom center of mass when exporting a GLTF from Godot, or not. I would tend towards keeping the node positions the same instead of moving them around, but it would also make sense to adjust the node positions. In this PR I only changed the import behavior, and made a warning on export, but if it's desired I can also change the export behavior to bake in the center of mass. In either case I'm not worried about it, since it's not common to need this when building a physics object in the editor.