Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve touchpad and mouse support for the Android editor #77498

Merged
merged 1 commit into from
May 27, 2023
Merged

Improve touchpad and mouse support for the Android editor #77498

merged 1 commit into from
May 27, 2023
+63 −17

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented May 26, 2023

  • Fix issues with using a touchpad to click, drag, interact with the navigation controls, etc..
  • Fix issues with panning with 2+ fingers
  • Fix issues with using double-tap to magnify on the spatial editor

3.x version

@m4gr3d
Improve touchpad and mouse support for the Android editor
01ee00f 
- Fix issues with using a touchpad to click, drag, interact with the navigation controls, etc..
- Fix issues with panning with 2+ fingers
- Fix issues with using double-tap to magnify on the spatial editor
@m4gr3d m4gr3d added this to the 4.1 milestone May 26, 2023
@m4gr3d m4gr3d requested a review from a team as a code owner May 26, 2023 03:29
@m4gr3d m4gr3d mentioned this pull request May 26, 2023
Merged
lawnjelly
lawnjelly approved these changes May 27, 2023
View reviewed changes
Copy link
Member

@lawnjelly lawnjelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I've only tested the 3.x version, but I'm presuming they both work the same.
Also I'm not an expert at the Android java, so have just been concentrating on the logic.

YuriSizov
YuriSizov approved these changes May 27, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is isolated to the particular platform code and done with expertise, I think that's sufficient testing, we can give it a go.

@YuriSizov YuriSizov merged commit e730a5b into godotengine:master May 27, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@m4gr3d m4gr3d deleted the improve_touchpad_mouse_support_main branch May 29, 2023 15:53
m4gr3d added a commit to m4gr3d/godot that referenced this pull request Jun 10, 2023
@m4gr3d
Fix spatial viewport multitouch detection support
2c050cc 
Regression introduced by godotengine#77498
@m4gr3d m4gr3d mentioned this pull request Jun 10, 2023
Merged
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.4 together with #78083.

YuriSizov pushed a commit to YuriSizov/godot that referenced this pull request Jun 29, 2023
@m4gr3d @YuriSizov
Fix spatial viewport multitouch detection support
bbfd991 
Regression introduced by godotengine#77498

(cherry picked from commit 2c050cc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

@lawnjelly lawnjelly lawnjelly approved these changes

Assignees
No one assigned
Labels
bug platform:android topic:input topic:porting
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@m4gr3d @YuriSizov @lawnjelly