Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] RichTextLabel: Cache text property when toggling BBCode #77403

Merged
merged 1 commit into from
Jun 7, 2023
Merged

[3.x] RichTextLabel: Cache text property when toggling BBCode #77403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions scene/gui/rich_text_label.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2741,8 +2741,17 @@ void RichTextLabel::set_use_bbcode(bool p_enable) {
if (use_bbcode == p_enable) {
return;
}

if (p_enable) {
cached_text = get_text();
}

use_bbcode = p_enable;
set_bbcode(bbcode);

if (!p_enable) {
set_text(cached_text);
}
property_list_changed_notify();
}

Expand Down
1 change: 1 addition & 0 deletions scene/gui/rich_text_label.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,7 @@ class RichTextLabel : public Control {

bool use_bbcode;
String bbcode;
String cached_text;

int fixed_width;

Expand Down