Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] GDNative: Add Core API 1.4, move Transform2D::determinant there #77387

Merged
merged 1 commit into from
May 23, 2023

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented May 23, 2023

It was added in #76323 but broke compatibility by being introduced in an already released core API (1.0).

Fixes #77283.

@necrashter I haven't tested the change, could you confirm that it fixes the issue?

It was added in godotengine#77283 but broke compatibility by being introduced in
an already released core API (1.0).

Fixes godotengine#77283.
Copy link
Contributor

@necrashter necrashter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that this fixes #77283. Thank you!

Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about this, but this fix is great! (I have not tested it)

@akien-mga akien-mga changed the title GDNative: Add Core API 1.4, move Transform2D::determinant there [3.x] GDNative: Add Core API 1.4, move Transform2D::determinant there May 23, 2023
@akien-mga akien-mga merged commit 68c507f into godotengine:3.x May 23, 2023
@akien-mga akien-mga deleted the 3.x-gdnative-core-1-4 branch May 23, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants