Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TouchScreenButton connections reference counted #77161

Merged
merged 1 commit into from
May 18, 2023
Merged

Make TouchScreenButton connections reference counted #77161

merged 1 commit into from
May 18, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented May 17, 2023 •
edited
Loading

Prevents errors when assigning the same texture to both slots

Follows up on #75016, which was cherry picked (so this error can occur on 4.0.3)

@AThousandShips AThousandShips requested a review from a team as a code owner May 17, 2023 14:15
@YuriSizov YuriSizov added this to the 4.1 milestone May 17, 2023
KoBeWi
KoBeWi approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say the comment is unnecessary, but the fix is correct.

@AThousandShips
Copy link
Member Author

AThousandShips commented May 17, 2023 •
edited
Loading

I'll just go ahead and remove it, took it from other usage to clarify but should be obvious why this is the case from the code

@AThousandShips
Make TouchScreenButton connections reference counted
0648cc6 
Prevents errors when assigning the same texture to both slots
@YuriSizov YuriSizov merged commit 0032c1c into godotengine:master May 18, 2023
@YuriSizov
Copy link
Contributor

Thanks! Cherry-picked for 4.0.3 as well.

@AThousandShips AThousandShips deleted the touch_texture_fix branch May 18, 2023 17:20
@AThousandShips
Copy link
Member Author

Thank you!

@AThousandShips AThousandShips mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:2d
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@AThousandShips @YuriSizov @KoBeWi