[3.x] Input: Fix just pressed and released with short presses #77040
+60
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawnjelly
force-pushed
the
input_just_pressed
branch
from
7df5842
to
c080e9e
Compare
lawnjelly
changed the title
Previously if an action was both pressed and released on the same tick or frame, `is_action_just_pressed()` would return false, resulting in missed input. This PR separately the timestamp for pressing and releasing so each can be tested independently.
lawnjelly
force-pushed
the
input_just_pressed
branch
from
c080e9e
to
63d208d
Compare
akien-mga
approved these changes
Jun 12, 2023
|
Thanks! |
akien-mga
changed the title
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if an action was both pressed and released on the same tick or frame,
is_action_just_pressed()would return false, resulting in missed input.This PR separately the timestamp for pressing and releasing so each can be tested independently.
Fixes #73339
3.x version of #77055 (see that PR for details)
Notes
processbecomesidlein 3.x).