Fix EnumDevices stall using a proxy DLL#76810
Fix EnumDevices stall using a proxy DLL#76810funkkiy wants to merge 2 commits intogodotengine:masterfrom
EnumDevices stall using a proxy DLL#76810Conversation
EnumDevices stall (#20566) using a proxy DLLEnumDevices stall using a proxy DLL
|
Please amend the commit name - since we are not using links in it. |
|
Will do when I get home. I'd like to note @bruvzg also suggested another approach, by reimplementing |
Corrected. |
|
Since this fixes a bug reported as far as Godot 3.0, I think it's safe to move it to the next milestone. Needs a review still from area maintainers, so cc @bruvzg |
I think other contributors suggested this wasn't the best solution, but I can't think of anything else other than someone going in and reimplementing the DirectInput functionality directly with the HID layer or using SDL's better implementation. |
|
This should go in, it fixes a very annoying issue that's very hard to figure out if you've got it |
|
Really hope this gets added soon, it is a very important fix as I am nearly unable to do anything without the engine slowing down and hanging. |
|
Superseded by #113013. Thanks for the contribution! |
If added, this PR will build a proxy library for
hid.dllthat pursues to resolve a very rare bug that hangs Godot when some devices are present, as seen in #20566. I have not been able to reproduce the issue because I don't own hardware that causes it, but previous experimentation has showed success when modifyingHidD_GetProductStringat runtime (#20566 (comment)).If needed, I can keep this as a draft so we can work anything out.
Bugsquad edit: