Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mono audio support to WASAPI #76541

Merged
merged 1 commit into from
May 12, 2023
Merged

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Apr 28, 2023

Co-authored by anonymous contributor (it's not my code, I'm just opening the PR)

This is pretty much copy-paste from PulseAudio.

Fixes #25875
Fixes (?) #75109 (the issue seems a bit different, needs to be tested)

@KoBeWi KoBeWi added this to the 4.1 milestone Apr 28, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner April 28, 2023 11:35
@akien-mga akien-mga added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Apr 28, 2023
@akien-mga
Copy link
Member

CC @bruvzg - from what I saw in #25875 (comment) this may also be needed for CoreAudio.

@bruvzg
Copy link
Member

bruvzg commented Apr 28, 2023

from what I saw in #25875 (comment) this may also be needed for CoreAudio.

Yes, it probably will need something similar.

@akien-mga akien-mga merged commit 373f2a8 into godotengine:master May 12, 2023
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.0.3.

@KoBeWi KoBeWi deleted the WAZZUP branch May 12, 2023 12:12
mrTag pushed a commit to ChasingCarrots/godot that referenced this pull request May 30, 2023
@akien-mga
Copy link
Member

Cherry-picked for 3.6.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Aug 28, 2023
@akien-mga
Copy link
Member

Cherry-picked for 3.5.3.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distorted sound on Windows with Corsair or SteelSeries Wireless Headset
3 participants