Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] MessageQueue - Fix max usage performance statistic #76533

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

lawnjelly
Copy link
Member

Fixes to keep track of the maximum usage over time, rather than current usage.

Fixes #76518
Regression from #75527

Notes

  • Now the queue is growable / shrinkable, the more interesting statistic is now the current allocated size, but this is left for another PR.
  • The statistic here is in theory useful to know you are nowhere near blowing the message queue, but the defaults limits are far higher now after [3.x] Make MessageQueue growable #75527 , so this is unlikely to happen.

Fixes to keep track of the maximum usage over time, rather than current usage.
@lawnjelly lawnjelly requested a review from a team as a code owner April 28, 2023 08:08
@akien-mga akien-mga added this to the 3.6 milestone Apr 28, 2023
@akien-mga akien-mga merged commit adee8cf into godotengine:3.x Apr 28, 2023
@akien-mga
Copy link
Member

Thanks!

@lawnjelly lawnjelly deleted the message_queue_perf branch April 28, 2023 17:15
@akien-mga akien-mga changed the title MessageQueue - Fix max usage performance statistic [3.x] MessageQueue - Fix max usage performance statistic Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants