Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter for AnimationNodeBlend3 #76506

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Daylily-Zeleen
Copy link
Contributor

@Daylily-Zeleen Daylily-Zeleen commented Apr 27, 2023

Befor:

blend3without_filtering.mp4

After:

blend3with_filering.mp4

Refer to this discussion.

@TokageItLab
Copy link
Member

For consistency, it looks like Add3 needs the same fix.

@Daylily-Zeleen
Copy link
Contributor Author

For consistency, it looks like Add3 needs the same fix.

I know that Add3 behabior is quite weird,but I still not found out the reason.

@TokageItLab
Copy link
Member

Isn't it because of the extra REST that is added? I will send a Sub2 PR later.

@Daylily-Zeleen
Copy link
Contributor Author

Daylily-Zeleen commented May 1, 2023

Isn't it because of the extra REST that is added? I will send a Sub2 PR later.

Yes, but it is quite complicated and I don't know how to fix it.

Will it be fixed In your Sub2 PR?

@TokageItLab
Copy link
Member

See #76616.

@DMDoom
Copy link

DMDoom commented May 15, 2024

Is anything happening with this? I checked these changes out in Godot 4.3 (more or less ef01922) and it works well. I see no reason why Add3 should have filtering and Blend3 not. I have not found any way to achieve the same result that Blend3 with filtering produces, and I find there are good use cases for this, e.g. blending player looking up/down with the current state machine animation — you'd only want to affect the upper body. You can do this with IK but I found this to be unnecessarily complex for my use, especially with more complicated models (not to mention SkeletonIK3D is deprecated, and skeleton modification stack was removed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants