Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import: Fix Silhouette used incorrect index. #76499

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

lyuma
Copy link
Contributor

@lyuma lyuma commented Apr 27, 2023

PostImportPluginSkeletonRestFixer: Fixes bind pose mistake from using i (mesh skin index) instead of bone_idx (skeleton bone index).
Fixes #76448

image showing properly t-posed skeleton

Fixes bind pose mistake from using i (mesh skin index) instead of bone_idx (skeleton bone index).
Fixes godotengine#76448
Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this fix, but if Use Named Skin option is turned off, retarget will not work and it may need to be fixed in the future separately from this.

@akien-mga akien-mga merged commit 0fc3ba2 into godotengine:master Apr 27, 2023
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Silhoutte breaks some meshes in A-Pose
3 participants