Fix editor spin slider remaining editable if set read_only
during and edit and fix related animation player crash
#76122
+14
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash in the animation player.
The easiest way to reproduce it is to open 2 scenes, one with an animation player and any other one.
First select and focus the line edit for the snap step, then switch to another scene.
Two issues are noticeable:
The changes on editor_spin_slider makes it so the line edit is correctly unfocused and un-selected if it becomes read only mid-edit.
The animation_track_editor check is just a sanity check and is not strictly necessary with the editor spin slider changes