Fix rotation issue with NODE_POSITION_VIEW shader built-in
#76109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddy-exe
changed the title
|
So I compiled the editor and these changes solved the issue. Thanks! 0001-0432.mp4 |
Great to hear, thanks for testing! |
This was referenced Apr 18, 2023
clayjohn
approved these changes
May 3, 2023
paddy-exe
force-pushed
the
fix-node-position-view
branch
from
fc9e1f5
to
e35bbd7
Compare
|
Quick rebase for a merge :D |
mhilbrunner
approved these changes
May 5, 2023
|
Thanks! Merged. |
akien-mga
changed the title
NODE_POSITION_VIEW shader built-in
|
Cherry-picked for 4.0.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75896
Somehow I can't test the compiled editor since the changes do not change anything for me locally... but I used the matrices separately just like in the source code here:
Fix-VisualShader-NodePosiitonView.mov
Fix-NodePositionView-Showcase.mov