Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential null in android text entry system. #75991

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Fix potential null in android text entry system. #75991

merged 1 commit into from
Apr 13, 2023

Conversation

jasonwinterpixel
Copy link
Contributor

@jasonwinterpixel jasonwinterpixel commented Apr 12, 2023 •
edited
Loading

3.x version

Fix a potential null in the android text entry system.

Note the documentation says this value can be null:
https://developer.android.com/reference/android/view/KeyEvent#getCharacters()

@jasonwinterpixel jasonwinterpixel requested a review from a team as a code owner April 12, 2023 15:19
@jasonwinterpixel jasonwinterpixel mentioned this pull request Apr 12, 2023
Merged
@akien-mga akien-mga added this to the 4.1 milestone Apr 12, 2023
@akien-mga akien-mga merged commit 3e37f23 into godotengine:master Apr 13, 2023
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@m4gr3d m4gr3d m4gr3d approved these changes

Assignees
No one assigned
Labels
bug crash platform:android topic:input topic:porting
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@jasonwinterpixel @akien-mga @YuriSizov @m4gr3d