Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Add tab Metadata to Tabs & TabContainer #75959

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

ShadyChibinko
Copy link
Contributor

Implements godotengine/godot-proposals#6664

This PR adds two new methods to TabContainer & Tabs for getting and setting metadata on individual tabs.

  • For Tabs, I simply mirrored the way metadata is handled in ItemList & TreeItem, and added a Variant metadata; variable to the Tab struct.
  • For TabContainer, metadata is saved on the tab control itself as meta, which is in line with how methods such as set_tab_title() and set_tab_icon() work.

@ShadyChibinko ShadyChibinko requested review from a team as code owners April 12, 2023 01:41
@ShadyChibinko ShadyChibinko changed the title [3.x] Add tab Metadata to Tabs & Tab Container [3.x] Add tab Metadata to Tabs & TabContainer Apr 12, 2023
@YeldhamDev YeldhamDev added this to the 3.6 milestone Apr 12, 2023
@akien-mga akien-mga merged commit f742d98 into godotengine:3.x Jun 7, 2023
@akien-mga
Copy link
Member

Thanks!

@ShadyChibinko ShadyChibinko deleted the tab_metadata_3x branch June 7, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants