Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creation of rendering buffers at any time #75937

Merged
merged 1 commit into from
May 8, 2023

Conversation

RandomShaper
Copy link
Member

This is needed for multi-threaded loading of geometry data.

This PR only touches buffers because textures are already allowed for this. They only error while a draw/compute list is open if the draw command list is used. Since buffer creation never uses the draw command list, this is safe.

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, these all use the setup command buffer so they won't conflict with the creation of the draw list anyway

@akien-mga akien-mga merged commit 392fdd1 into godotengine:master May 8, 2023
@RandomShaper RandomShaper deleted the threaded_render_load branch May 8, 2023 11:59
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants