Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of main.cpp. #75548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Commits on Apr 1, 2023

  1. Improve readability.

    1) Be consistent with spacing in if, else if, else blocks.
       Removed empty lines at the beginning and end.
       Previously, some blocks had no extra empty lines, while other blocks
       had one at the beginning, end, or both.
    
    2) Add underscores to variable names like hasicon and iconpath.
       Other files used icon_path, so now main.cpp does the same.
    
    3) Reduce the number of times OS::get_singleton() appears.
       Some functions like print_help() look less visually noisy. This helps
       the reader while skimming the source code.
    
       Added OS *os = OS::get_singleton(); to the eight functions that use the
       OS singleton. These functions were modified:
    
         print_help(const char *)
         test_setup()
         test_cleanup()
         setup(const char *, int, char * [], bool)
         setup2(Thread::ID)
         start()
         iteration()
         cleanup(bool)
    ronyeh committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    8790a0e View commit details
    Browse the repository at this point in the history