Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-one issue where "Go to Line" dialog shows the incorrect line number (one less than the actual current line). #75523

Merged
merged 1 commit into from
Apr 2, 2023
Merged

Fix off-by-one issue where "Go to Line" dialog shows the incorrect line number (one less than the actual current line). #75523

merged 1 commit into from
Apr 2, 2023
+11 −8

Conversation

ronyeh
Copy link
Contributor

@ronyeh ronyeh commented Mar 31, 2023

To repro:

  1. In a code editor, press CMD+L to show the Go to Line popup dialog.
  2. The line number is incorrect. If you are on line 1, it shows 0. If you are on line 10, it shows 9.
  3. Press Enter without typing anything else. The caret now moves up one line.
  4. If you repeat steps 1 through 3, the text cursor / caret will keep moving up one line at a time.

@ronyeh
Fix off-by-one issue where Go to Line dialog shows the incorrect line
1e9fd10 
number (one less than the actual current line).
@ronyeh ronyeh requested a review from a team as a code owner March 31, 2023 06:43
@ronyeh ronyeh changed the title Fix off-by-one issue where "Go to Line dialog" shows the incorrect line number (one less than the actual current line). Fix off-by-one issue where "Go to Line" dialog shows the incorrect line number (one less than the actual current line). Mar 31, 2023
@kleonc kleonc added this to the 4.1 milestone Mar 31, 2023
@akien-mga akien-mga merged commit 11b7f55 into godotengine:master Apr 2, 2023
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleonc kleonc kleonc approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ronyeh @akien-mga @YuriSizov @kleonc