Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow selecting nodes without owner #75492

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Don't allow selecting nodes without owner #75492

merged 1 commit into from
Mar 30, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Mar 30, 2023

Nodes without owner (aside from scene root) are not visible in scene tree and are not saved, so they shouldn't be selectable.

Fixes #69873
Fixes #75445

@KoBeWi KoBeWi added this to the 4.1 milestone Mar 30, 2023
YuriSizov
YuriSizov approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, but you have an extra space, failing the CI

@YuriSizov YuriSizov merged commit 6612068 into godotengine:master Mar 30, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@KoBeWi KoBeWi deleted the you_shall_not_select! branch March 30, 2023 16:24
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:2d
Projects
None yet
Milestone
4.1
2 participants
@KoBeWi @YuriSizov