Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# Truncate instead of round in Vector2/3/4 to Vector2I/3I/4I conversion #75477

Merged
merged 1 commit into from
Mar 31, 2023
Merged

C# Truncate instead of round in Vector2/3/4 to Vector2I/3I/4I conversion #75477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/classes/Vector2i.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<return type="Vector2i" />
<param index="0" name="from" type="Vector2" />
<description>
Constructs a new [Vector2i] from [Vector2]. The floating point coordinates will be truncated.
Constructs a new [Vector2i] from the given [Vector2] by truncating components' fractional parts (rounding towards zero). For a different behavior consider passing the result of [method Vector2.ceil], [method Vector2.floor] or [method Vector2.round] to this constructor instead.
</description>
</constructor>
<constructor name="Vector2i">
Expand Down
2 changes: 1 addition & 1 deletion doc/classes/Vector3i.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<return type="Vector3i" />
<param index="0" name="from" type="Vector3" />
<description>
Constructs a new [Vector3i] from [Vector3]. The floating point coordinates will be truncated.
Constructs a new [Vector3i] from the given [Vector3] by truncating components' fractional parts (rounding towards zero). For a different behavior consider passing the result of [method Vector3.ceil], [method Vector3.floor] or [method Vector3.round] to this constructor instead.
</description>
</constructor>
<constructor name="Vector3i">
Expand Down
2 changes: 1 addition & 1 deletion doc/classes/Vector4i.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<return type="Vector4i" />
<param index="0" name="from" type="Vector4" />
<description>
Constructs a new [Vector4i] from the given [Vector4].
Constructs a new [Vector4i] from the given [Vector4] by truncating components' fractional parts (rounding towards zero). For a different behavior consider passing the result of [method Vector4.ceil], [method Vector4.floor] or [method Vector4.round] to this constructor instead.
</description>
</constructor>
<constructor name="Vector4i">
Expand Down
10 changes: 5 additions & 5 deletions modules/mono/glue/GodotSharp/GodotSharp/Core/Vector2I.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,15 +504,15 @@ public static implicit operator Vector2(Vector2I value)
}

/// <summary>
/// Converts a <see cref="Vector2"/> to a <see cref="Vector2I"/>.
/// Converts a <see cref="Vector2"/> to a <see cref="Vector2I"/> by truncating
/// components' fractional parts (rounding towards zero). For a different
/// behavior consider passing the result of <see cref="Vector2.Ceil"/>,
/// <see cref="Vector2.Floor"/> or <see cref="Vector2.Round"/> to this conversion operator instead.
/// </summary>
/// <param name="value">The vector to convert.</param>
public static explicit operator Vector2I(Vector2 value)
{
return new Vector2I(
Mathf.RoundToInt(value.X),
Mathf.RoundToInt(value.Y)
);
return new Vector2I((int)value.X, (int)value.Y);
}

/// <summary>
Expand Down
11 changes: 5 additions & 6 deletions modules/mono/glue/GodotSharp/GodotSharp/Core/Vector3I.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,16 +559,15 @@ public static implicit operator Vector3(Vector3I value)
}

/// <summary>
/// Converts a <see cref="Vector3"/> to a <see cref="Vector3I"/>.
/// Converts a <see cref="Vector3"/> to a <see cref="Vector3I"/> by truncating
/// components' fractional parts (rounding towards zero). For a different
/// behavior consider passing the result of <see cref="Vector3.Ceil"/>,
/// <see cref="Vector3.Floor"/> or <see cref="Vector3.Round"/> to this conversion operator instead.
/// </summary>
/// <param name="value">The vector to convert.</param>
public static explicit operator Vector3I(Vector3 value)
{
return new Vector3I(
Mathf.RoundToInt(value.X),
Mathf.RoundToInt(value.Y),
Mathf.RoundToInt(value.Z)
);
return new Vector3I((int)value.X, (int)value.Y, (int)value.Z);
}

/// <summary>
Expand Down
12 changes: 5 additions & 7 deletions modules/mono/glue/GodotSharp/GodotSharp/Core/Vector4I.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,17 +580,15 @@ public static implicit operator Vector4(Vector4I value)
}

/// <summary>
/// Converts a <see cref="Vector4"/> to a <see cref="Vector4I"/>.
/// Converts a <see cref="Vector4"/> to a <see cref="Vector4I"/> by truncating
/// components' fractional parts (rounding towards zero). For a different
/// behavior consider passing the result of <see cref="Vector4.Ceil"/>,
/// <see cref="Vector4.Floor"/> or <see cref="Vector4.Round"/> to this conversion operator instead.
/// </summary>
/// <param name="value">The vector to convert.</param>
public static explicit operator Vector4I(Vector4 value)
{
return new Vector4I(
Mathf.RoundToInt(value.X),
Mathf.RoundToInt(value.Y),
Mathf.RoundToInt(value.Z),
Mathf.RoundToInt(value.W)
);
return new Vector4I((int)value.X, (int)value.Y, (int)value.Z, (int)value.W);
}

/// <summary>
Expand Down